Skip to content

ci(gh-actions): resolve zizmor findings#3449

Merged
madhavilosetty-intel merged 1 commit into
mainfrom
ci/fix-zizmor-findings
Jul 20, 2026
Merged

ci(gh-actions): resolve zizmor findings#3449
madhavilosetty-intel merged 1 commit into
mainfrom
ci/fix-zizmor-findings

Conversation

@madhavilosetty-intel

Copy link
Copy Markdown
Contributor

Fix template-injection and artipacked findings, suppress the intentional dependabot-cooldown warnings.

  • docker.yaml: move workflow_dispatch inputs into env: so they are no longer expanded into the run: shell (template-injection).
  • add persist-credentials: false to checkout in the seven workflows that never push to git (artipacked); release.yml keeps credentials.
  • add .github/zizmor.yml to suppress dependabot-cooldown for the intentional no-cooldown daily update cadence.

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

Fix template-injection and artipacked findings, suppress the
intentional dependabot-cooldown warnings.

- docker.yaml: move workflow_dispatch inputs into env: so they are no
  longer expanded into the run: shell (template-injection).
- add persist-credentials: false to checkout in the seven workflows
  that never push to git (artipacked); release.yml keeps credentials.
- add .github/zizmor.yml to suppress dependabot-cooldown for the
  intentional no-cooldown daily update cadence.

@graikhel-intel graikhel-intel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first test PR to address some of the findings reported by Zizmor. If the changes look correct, Madhavi plans to apply the same fixes to the other repositories. Additional PRs will follow to address the remaining findings.

@madhavilosetty-intel
madhavilosetty-intel merged commit 12f1521 into main Jul 20, 2026
10 checks passed
@madhavilosetty-intel
madhavilosetty-intel deleted the ci/fix-zizmor-findings branch July 20, 2026 21:00
@RosieAMT

Copy link
Copy Markdown

🎉 This PR is included in version 3.61.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@graikhel-intel

Copy link
Copy Markdown
Contributor

@madhavilosetty-intel with this merged, I don’t see any remaining Zizmor warnings in code scanning, so you can apply similar changes to the other repositories: https://github.com/device-management-toolkit/sample-web-ui/security/code-scanning

These changes also don’t appear to be breaking anything in our releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants